[GitHub] ivankelly opened a new pull request #898: Bookies should prioritize recovery reads/writes

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #898: Bookies should prioritize recovery reads/writes
URL: https://github.com/apache/bookkeeper/pull/898
 
 
   The change adds a new flag for reads, RECOVERY_READ. This flag is set
   when a client is retrying to recover a ledger. Recovery reads should
   be higher priority than normal reads, as recovery usually happens when
   a writer has failed, and another node needs to take over the stream
   that that ledger belonged to. All writes on that stream are blocked
   until the ledger the ledger has been recovered, so giving these reads
   priority will mean the stream is out for action for the shortest
   amount of time possible.
   
   Priority is given to these reads by executing the reads directly in
   the BookieRequestProcessor, rather than adding them to the
   readThreadPool where they could end up queuing.
   
   This change was originally 372a99db in the yahoo.
   
   Descriptions of the changes in this PR:
   
   (PR description content here)...
   
   Master Issue: #<master-issue-number>
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue # or BOOKKEEPER-#>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   >     `e.g. BOOKKEEPER-1234: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services