You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by marcaurele <gi...@git.apache.org> on 2016/11/15 09:33:34 UTC
[GitHub] cloudstack pull request #1764: Should not fetch resource count for removed e...
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1764
Should not fetch resource count for removed entity
Fetch the number of resourceCount by domain and account excluding the removed ones.
Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exoscale/cloudstack fix/CLOUDSTACK-9597
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1764
----
commit 267597174140009e6717de15030021c36cf27877
Author: Marc-Aur�le Brothier <m...@brothier.org>
Date: 2016-11-15T08:39:11Z
Should not fetch resource count for removed entity
Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1764
@marcaurele can you add the JIRA id in the git commit message, and push -f to re-kick Travis?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1764: CLOUDSTACK-9597: Should not fetch resource co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1764
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1764
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1764
<b>Trillian test result (tid-546)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29500 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1764-t546-kvm-centos7.zip
Test completed. 48 look ok, 0 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn | Success | 170.56 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.40 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 265.94 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 308.75 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 541.80 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 517.95 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1427.77 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 616.65 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 770.24 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1373.34 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.48 | test_volumes.py
test_08_resize_volume | Success | 15.42 | test_volumes.py
test_07_resize_fail | Success | 20.52 | test_volumes.py
test_06_download_detached_volume | Success | 15.35 | test_volumes.py
test_05_detach_volume | Success | 100.29 | test_volumes.py
test_04_delete_attached_volume | Success | 10.29 | test_volumes.py
test_03_download_attached_volume | Success | 15.32 | test_volumes.py
test_02_attach_volume | Success | 45.09 | test_volumes.py
test_01_create_volume | Success | 758.84 | test_volumes.py
test_deploy_vm_multiple | Success | 339.53 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.08 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 185.28 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 71.22 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 126.05 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.32 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.37 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 105.89 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.33 | test_templates.py
test_03_delete_template | Success | 5.12 | test_templates.py
test_02_edit_template | Success | 90.12 | test_templates.py
test_01_create_template | Success | 65.64 | test_templates.py
test_10_destroy_cpvm | Success | 192.07 | test_ssvm.py
test_09_destroy_ssvm | Success | 164.98 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.59 | test_ssvm.py
test_07_reboot_ssvm | Success | 163.68 | test_ssvm.py
test_06_stop_cpvm | Success | 162.09 | test_ssvm.py
test_05_stop_ssvm | Success | 134.07 | test_ssvm.py
test_04_cpvm_internals | Success | 1.36 | test_ssvm.py
test_03_ssvm_internals | Success | 6.39 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.17 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.36 | test_snapshots.py
test_04_change_offering_small | Success | 239.70 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 40.36 | test_routers.py
test_08_start_router | Success | 50.43 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.07 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.76 | test_routers.py
test_03_restart_network_cleanup | Success | 65.65 | test_routers.py
test_02_router_internal_adv | Success | 1.10 | test_routers.py
test_01_router_internal_basic | Success | 0.62 | test_routers.py
test_router_dns_guestipquery | Success | 79.78 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py
test_router_dhcphosts | Success | 283.54 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.84 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.13 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 130.98 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.08 | test_regions.py
test_create_pvlan_network | Success | 5.26 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.65 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 752.50 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 733.31 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 447.81 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 139.73 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.83 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 10.25 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.55 | test_portable_publicip.py
test_isolate_network_password_server | Success | 120.60 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.18 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.78 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.42 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.29 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.38 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.40 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.41 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.38 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.36 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 87.76 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.20 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.54 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.34 | test_non_contigiousvlan.py
test_01_nic | Success | 546.22 | test_nic.py
test_releaseIP | Success | 254.29 | test_network.py
test_reboot_router | Success | 496.31 | test_network.py
test_public_ip_user_account | Success | 10.30 | test_network.py
test_public_ip_admin_account | Success | 40.42 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 67.02 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.87 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 154.67 | test_network.py
test_delete_account | Success | 329.93 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.94 | test_network.py
test_01_port_fwd_on_src_nat | Success | 112.74 | test_network.py
test_nic_secondaryip_add_remove | Success | 240.01 | test_multipleips_per_nic.py
login_test_saml_user | Success | 26.16 | test_login.py
test_assign_and_removal_lb | Success | 135.15 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.63 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 228.20 | test_loadbalance.py
test_03_list_snapshots | Success | 0.08 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.05 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.05 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.07 | test_iso.py
test_05_iso_permissions | Success | 0.08 | test_iso.py
test_04_extract_Iso | Success | 5.52 | test_iso.py
test_03_delete_iso | Success | 95.22 | test_iso.py
test_02_edit_iso | Success | 0.07 | test_iso.py
test_01_create_iso | Success | 22.24 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 340.79 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 274.83 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 582.24 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 455.85 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.30 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 7.15 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 7.04 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 6.96 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 6.88 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 7.01 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 6.91 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.95 | test_dynamicroles.py
test_role_lifecycle_list | Success | 7.04 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 11.93 | test_dynamicroles.py
test_role_lifecycle_create | Success | 6.94 | test_dynamicroles.py
test_role_inuse_deletion | Success | 7.13 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 9.33 | test_dynamicroles.py
test_role_account_acls | Success | 9.72 | test_dynamicroles.py
test_default_role_deletion | Success | 7.01 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.08 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.06 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.09 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.60 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.63 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 85.88 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.56 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 55.94 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 7.03 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.97 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 273.96 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 213.79 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 121.90 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.04 | test_staticroles.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1764
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1764
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1764
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Packaging result: \u2714centos6 \u2714centos7 \u2716debian. JID-169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Tested the fix manually it looks OK. Smoketests results also looking good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Thanks @marcaurele
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...
Posted by marcaurele <gi...@git.apache.org>.
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Will fix the checks in `ConfigurationServerImpl`:
- https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/server/ConfigurationServerImpl.java#L1426
- https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/server/ConfigurationServerImpl.java#L1455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---