You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/10 12:45:40 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #222: [YUNIKORN-465] scheduler health check REST API
codecov[bot] edited a comment on pull request #222:
URL: https://github.com/apache/incubator-yunikorn-core/pull/222#issuecomment-737230264
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=h1) Report
> Merging [#222](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=desc) (9238807) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/bdb0a51210778ab8f2d1a0cec6b9d8563a018113?el=desc) (bdb0a51) will **decrease** coverage by `0.21%`.
> The diff coverage is `53.27%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
- Coverage 63.09% 62.87% -0.22%
==========================================
Files 59 60 +1
Lines 4875 4962 +87
==========================================
+ Hits 3076 3120 +44
- Misses 1657 1693 +36
- Partials 142 149 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/common/resources/resources.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcmVzb3VyY2VzLmdv) | `96.02% <0.00%> (-1.50%)` | :arrow_down: |
| [pkg/metrics/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3Mvc2NoZWR1bGVyLmdv) | `61.58% <0.00%> (-3.69%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `54.13% <0.00%> (-0.95%)` | :arrow_down: |
| [pkg/webservice/healthcheck/health\_checker.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrZXIuZ28=) | `65.88% <65.88%> (ø)` | |
| [pkg/metrics/init.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3MvaW5pdC5nbw==) | `62.96% <100.00%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `54.27% <0.00%> (-1.04%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `64.89% <0.00%> (-0.01%)` | :arrow_down: |
| [pkg/scheduler/objects/node.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `85.30% <0.00%> (+1.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=footer). Last update [01f5288...73aa040](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org