[jira] [Commented] (EMAIL-118) smtpPort setter and getter doesn't works with the same type in EmailClass

["Thomas Neidhart (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/EMAIL-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492765#comment-13492765 ] 

Thomas Neidhart commented on EMAIL-118:
---------------------------------------

Pushing to 2.0 as it would break compatibility.

Looking at the code, it is not quite clear why the port is actually stored as a String. It is put into the Session object, which requires a String value, but it could also be converted for this purpose.

The same btw applies also to the sslSmtpPort property.
                
> smtpPort setter and getter doesn't works with the same type in EmailClass
> -------------------------------------------------------------------------
>
>                 Key: EMAIL-118
>                 URL: https://issues.apache.org/jira/browse/EMAIL-118
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Xavier Detant
>            Priority: Trivial
>              Labels: patch
>             Fix For: 2.0
>
>         Attachments: SmtpAsInt.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The smtpPort in the Email class can be set as an int but is get as a String. This is quite bad design, the getter and the setter should works with the same type. As smtp ports is a number, the getter which is currently _public String getSmtpPort()_ should be _public int getSmtpPort()_:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira