You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "difin (via GitHub)" <gi...@apache.org> on 2024/12/04 23:11:24 UTC
Re: [PR] HIVE-28623: Implement RuntimeContext to decouple runtime data from TezTask [hive]
difin commented on code in PR #5538:
URL: https://github.com/apache/hive/pull/5538#discussion_r1870400053
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java:
##########
@@ -125,6 +130,17 @@ public QueryPlan getPlan() {
public void setPlan(QueryPlan plan) {
this.plan = plan;
+ // only set runtimeContext if the plan is not null
+ // we don't want to nullify runtimeContext if this method is called with plan=null, which is the case when e.g.
+ // driver.releasePlan() tries to release resources/objects that are known to be heavy
+ if (plan != null){
Review Comment:
nit: missing space between `){`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org