You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "JooHyukKim (via GitHub)" <gi...@apache.org> on 2023/06/19 15:27:47 UTC
[GitHub] [pulsar] JooHyukKim commented on a diff in pull request #20541: [improve][broker] Log warning on missing URL configuration for cluster creation/update
JooHyukKim commented on code in PR #20541:
URL: https://github.com/apache/pulsar/pull/20541#discussion_r1234211922
##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ClusterDataImpl.java:
##########
@@ -430,6 +430,8 @@ public void checkPropertiesIfPresent() throws IllegalArgumentException {
|| Objects.equals(uri.getScheme(), "pulsar+ssl"),
"Illegal proxy service url, example: pulsar+ssl://ats-proxy.example.com:4443 "
+ "or pulsar://ats-proxy.example.com:4080");
+
+ warnIfUrlIsNotPresent();
}
public void warnIfUrlIsNotPresent() {
Review Comment:
I was just gonna ask if this should at least be `protected`. But `private` seems more reasonable. Thank you @nodece! Modified accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org