You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Bhuvaneswaran Arumugam <bh...@collab.net> on 2007/10/05 16:14:06 UTC

[PATCH] Avoid traceback in a build script

Hello,

Please find attached a patch to avoid traceback if no argument is passed
for build/getversion.py script. 

If no argument is passed, identify the header file automatically. This
is just better than a traceback.

[[
Avoid traceback if no argument is passed.

* build/getversion.py
  (main): Do not import os library. Identify the header file 
  automatically, if it is not passed in command line. 

Patch by: bhuvan
]]
-- 
Regards,
Bhuvaneswaran

Re: [PATCH] Avoid traceback in a build script

Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.

On Fri, 05 Oct 2007, Bhuvaneswaran Arumugam wrote:

> On Fri, 2007-10-05 at 21:44 +0530, Bhuvaneswaran Arumugam wrote:
> > Hello,
> > 
> > Please find attached a patch to avoid traceback if no argument is passed
> > for build/getversion.py script. 
> > 
> > If no argument is passed, identify the header file automatically. This
> > is just better than a traceback.
> 
> Hello,
> 
> Please avoid the previous patch. I think, displaying a usage message is
> better than identifying the svn_version.h header file automatically
> using relative path. Please find attached a revised patch.
> 
> If no argument is passed, print the usage message. It is just better
> than a traceback.

I committed a patch based on your ideas in r26962 (a palindrome).

Re: [PATCH] Avoid traceback in a build script

Posted by Bhuvaneswaran Arumugam <bh...@collab.net>.

On Fri, 2007-10-05 at 21:44 +0530, Bhuvaneswaran Arumugam wrote:
> Hello,
> 
> Please find attached a patch to avoid traceback if no argument is passed
> for build/getversion.py script. 
> 
> If no argument is passed, identify the header file automatically. This
> is just better than a traceback.

Hello,

Please avoid the previous patch. I think, displaying a usage message is
better than identifying the svn_version.h header file automatically
using relative path. Please find attached a revised patch.

If no argument is passed, print the usage message. It is just better
than a traceback.

[[
Avoid traceback if no argument is passed.

* build/getversion.py
  (main): Do not import 'os' library. If header file is not passed in
  command line, display the usage message and exit. It is just better 
  than a traceback.

Patch by: bhuvan
]]

-- 
Regards,
Bhuvaneswaran