[jira] [Comment Edited] (CALCITE-2457) Upgrade to JUnit 5

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615330#comment-16615330 ] 

Vladimir Sitnikov edited comment on CALCITE-2457 at 9/14/18 8:19 PM:
---------------------------------------------------------------------

 {quote}Are we running at risk in adopting it too early ?{quote}

I don't think so.

I'm afraid it takes extreme amount of time to merge such kind of changes to Calcite (e.g. CALCITE-2458 was ready in 21 Aug, and still no comments). 

I think we should start now, and by the time we agree with Calcite fixes,  JUnit 5.3.2 might be released :)


was (Author: vladimirsitnikov):
 {quote}Are we running at risk in adopting it too early ?{quote}

I don't think so.

I'm afraid it takes extreme amount of time to merge such kind of changes to Calcite (e.g. CALCITE-2458 was ready in 21 Aug, and still no comments).
 

I think we should start now, and by the time we agree with Calcite fixes,  JUnit 5.3.2 might be released :)

 

 

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CALCITE-2457
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2457
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>         Attachments: assert_equals.png, truth_assertmap.png
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)