You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/20 18:18:58 UTC
[GitHub] [pulsar-helm-chart] claudio-vellage opened a new pull request, #286: Allow to use selectors with volumeClaimTemplates
claudio-vellage opened a new pull request, #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286
### Motivation
Currently it's not possible to use selectors with volumeClaimTemplates which makes it hard/impossible to bind statically provisioned PVs.
### Modifications
Added (optional) selectors to `volumeClaimTemplates` and documented in values file.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] claudio-vellage commented on pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
claudio-vellage commented on PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#issuecomment-1244292757
@lhotari is there anything left to do for me? Can this be assigned to someone for review? It's a rather small change which doesn't affect existing deployments, only adds additional functionality. It allows that selectors can be added to volumeClaimTemplates, which will allow to easily create PVCs which bind to existing PVs using selectors. This allows to reuse the same PVs even if all pulsar resources are deleted. This will be more robust for production deployments and avoid having to restore the content of the PVs manually in case of disaster recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#discussion_r998772076
##########
charts/pulsar/values.yaml:
##########
@@ -515,6 +519,10 @@ bookkeeper:
# type: pd-ssd
# fsType: xfs
# provisioner: kubernetes.io/gce-pd
+ ## If you want to bind static persistent volumes via selectors, e.g.:
+ # selectors:
+ # matchLabels:
+ # app: pulsar-bookkeeper-journal
Review Comment:
```suggestion
selector: {}
```
##########
charts/pulsar/values.yaml:
##########
@@ -383,6 +383,10 @@ zookeeper:
# type: pd-ssd
# fsType: xfs
# provisioner: kubernetes.io/gce-pd
+ ## If you want to bind static persistent volumes via selectors, e.g.:
+ # selectors:
+ # matchLabels:
+ # app: pulsar-zookeeper
Review Comment:
I think it is slightly more helpful to have a good zero value here. Also, we need `selector` not `selectors`.
```suggestion
## If you want to bind static persistent volumes via selectors, e.g.:
selector: {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] claudio-vellage commented on a diff in pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
claudio-vellage commented on code in PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#discussion_r999175319
##########
charts/pulsar/values.yaml:
##########
@@ -383,6 +383,10 @@ zookeeper:
# type: pd-ssd
# fsType: xfs
# provisioner: kubernetes.io/gce-pd
+ ## If you want to bind static persistent volumes via selectors, e.g.:
+ # selectors:
+ # matchLabels:
+ # app: pulsar-zookeeper
Review Comment:
I've made the changes, please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#issuecomment-1284916039
@claudio-vellage - are you able to resolve the merge conflicts? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#issuecomment-1285961335
Closing and reopening to get the latest test changes. (I am pretty sure we don't need to merge master into this branch to get the fix I just merge here #315, but that might be necessary.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall closed pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #286: Allow to use selectors with volumeClaimTemplates
URL: https://github.com/apache/pulsar-helm-chart/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] claudio-vellage commented on a diff in pull request #286: Allow to use selectors with volumeClaimTemplates
Posted by GitBox <gi...@apache.org>.
claudio-vellage commented on code in PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#discussion_r999175080
##########
charts/pulsar/values.yaml:
##########
@@ -515,6 +519,10 @@ bookkeeper:
# type: pd-ssd
# fsType: xfs
# provisioner: kubernetes.io/gce-pd
+ ## If you want to bind static persistent volumes via selectors, e.g.:
+ # selectors:
+ # matchLabels:
+ # app: pulsar-bookkeeper-journal
Review Comment:
I've made the changes, please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org