You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2023/11/27 12:11:06 UTC

[PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

morrySnow opened a new pull request, #27649:
URL: https://github.com/apache/doris/pull/27649

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1829284179

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1829189905

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #27649:
URL: https://github.com/apache/doris/pull/27649


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1827890761

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit aeafbdfe275c6938079cb6a76e2043c69216d903, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4940	4635	4657	4635
   q2	369	158	198	158
   q3	2057	1956	1910	1910
   q4	1405	1274	1232	1232
   q5	3994	3937	4009	3937
   q6	254	136	127	127
   q7	1404	876	881	876
   q8	2830	2811	2775	2775
   q9	9894	9830	9609	9609
   q10	3454	3513	3519	3513
   q11	375	241	248	241
   q12	443	289	304	289
   q13	4553	3852	3822	3822
   q14	316	294	305	294
   q15	582	532	522	522
   q16	661	580	576	576
   q17	1137	959	946	946
   q18	8018	7532	7545	7532
   q19	1676	1693	1677	1677
   q20	564	288	289	288
   q21	4519	4008	4045	4008
   q22	466	377	400	377
   Total cold run time: 53911 ms
   Total hot run time: 49344 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4599	4580	4586	4580
   q2	337	219	253	219
   q3	4053	4035	4032	4032
   q4	2740	2721	2718	2718
   q5	9694	9674	9676	9674
   q6	250	120	125	120
   q7	3049	2526	2464	2464
   q8	4461	4428	4411	4411
   q9	13233	13131	13217	13131
   q10	4085	4174	4157	4157
   q11	760	642	653	642
   q12	972	817	801	801
   q13	4302	3562	3593	3562
   q14	383	358	352	352
   q15	580	528	514	514
   q16	747	674	676	674
   q17	3836	3828	3910	3828
   q18	9677	9174	9098	9098
   q19	1811	1783	1776	1776
   q20	2378	2036	2045	2036
   q21	8830	8866	8792	8792
   q22	873	819	842	819
   Total cold run time: 81650 ms
   Total hot run time: 78400 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1829265337

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1827713727

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1829279084

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1829341721

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 3a5c735a2d8ed02a47cfee51bbb410afc90935c0, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4904	4656	4702	4656
   q2	361	151	162	151
   q3	2042	1900	1939	1900
   q4	1399	1275	1263	1263
   q5	3977	3938	3989	3938
   q6	255	131	134	131
   q7	1403	862	862	862
   q8	2849	2849	2790	2790
   q9	9631	9646	9601	9601
   q10	3450	3520	3532	3520
   q11	391	249	233	233
   q12	441	294	294	294
   q13	4541	3789	3817	3789
   q14	314	286	302	286
   q15	581	546	521	521
   q16	495	452	468	452
   q17	1145	981	952	952
   q18	7942	7571	7427	7427
   q19	1669	1691	1675	1675
   q20	579	317	304	304
   q21	4432	4017	4087	4017
   q22	465	373	373	373
   Total cold run time: 53266 ms
   Total hot run time: 49135 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4598	4582	4599	4582
   q2	332	228	257	228
   q3	4038	4025	4009	4009
   q4	2726	2706	2708	2706
   q5	9599	9582	9537	9537
   q6	249	125	124	124
   q7	3046	2508	2499	2499
   q8	4435	4451	4443	4443
   q9	12942	12822	12867	12822
   q10	4042	4192	4196	4192
   q11	801	646	676	646
   q12	969	811	818	811
   q13	4300	3554	3588	3554
   q14	380	352	341	341
   q15	581	511	517	511
   q16	598	567	600	567
   q17	3809	3922	3794	3794
   q18	9605	9129	9182	9129
   q19	1842	1803	1770	1770
   q20	2390	2097	2042	2042
   q21	8750	8749	8510	8510
   q22	906	825	842	825
   Total cold run time: 80938 ms
   Total hot run time: 77642 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1829323276

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.43 seconds
    stream load tsv:          564 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         29 seconds loaded 2358488459 Bytes, about 77 MB/s
    stream load orc:          69 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.6 seconds inserted 10000000 Rows, about 349K ops/s
    storage size: 17099035300 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1827751933

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) compound predicate need cast children to boolean [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27649:
URL: https://github.com/apache/doris/pull/27649#issuecomment-1827907242

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.14 seconds
    stream load tsv:          565 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         30 seconds loaded 2358488459 Bytes, about 74 MB/s
    stream load orc:          67 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.7 seconds inserted 10000000 Rows, about 348K ops/s
    storage size: 17099611314 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org