You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2006/08/21 22:29:40 UTC
svn commit: r433348 -
/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
Author: dennisl
Date: Mon Aug 21 13:29:39 2006
New Revision: 433348
URL: http://svn.apache.org/viewvc?rev=433348&view=rev
Log:
[MCHECKSTYLE-50] Sort the files and details in the report.
Modified:
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java?rev=433348&r1=433347&r2=433348&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java Mon Aug 21 13:29:39 2006
@@ -28,6 +28,7 @@
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.ResourceBundle;
@@ -518,7 +519,11 @@
sink.tableHeaderCell_();
sink.tableRow_();
- for ( Iterator files = results.getFiles().keySet().iterator(); files.hasNext(); )
+ // Sort the files before writing them to the report
+ ArrayList fileList = new ArrayList( results.getFiles().keySet() );
+ Collections.sort( fileList );
+
+ for ( Iterator files = fileList.iterator(); files.hasNext(); )
{
String filename = (String) files.next();
List violations = results.getFileViolations( filename );
@@ -563,7 +568,10 @@
sink.text( bundle.getString( "report.checkstyle.details" ) );
sink.sectionTitle1_();
- Iterator files = results.getFiles().keySet().iterator();
+ // Sort the files before writing their details to the report
+ ArrayList fileList = new ArrayList( results.getFiles().keySet() );
+ Collections.sort( fileList );
+ Iterator files = fileList.iterator();
while ( files.hasNext() )
{