You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/10 23:31:03 UTC
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2314: Spark: Refactor action for expiring snapshots
aokolnychyi commented on a change in pull request #2314:
URL: https://github.com/apache/iceberg/pull/2314#discussion_r591953966
##########
File path: spark/src/main/java/org/apache/iceberg/actions/Actions.java
##########
@@ -79,7 +80,8 @@ public RewriteDataFilesAction rewriteDataFiles() {
}
public ExpireSnapshotsAction expireSnapshots() {
- return new ExpireSnapshotsAction(spark, table);
+ BaseExpireSnapshotsSparkAction delegate = new BaseExpireSnapshotsSparkAction(spark, table);
+ return new ExpireSnapshotsAction(delegate);
Review comment:
This is a user-facing API so we cannot break it without deprecating first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org