You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/18 22:50:42 UTC

[GitHub] graceguo-supercat opened a new pull request #5241: [Explore] Handle empty metrics control data

graceguo-supercat opened a new pull request #5241: [Explore] Handle empty metrics control data
URL: https://github.com/apache/incubator-superset/pull/5241
 
 
   when metrics is empty, Explore controls throw exceptions:
   
   ![screen shot 2018-06-18 at 3 21 57 pm](https://user-images.githubusercontent.com/27990562/41565854-64da6c26-730d-11e8-95a4-e0b803fb8d87.png)
   <img width="1299" alt="screen shot 2018-06-18 at 3 38 31 pm" src="https://user-images.githubusercontent.com/27990562/41565904-be5a676a-730d-11e8-9dc1-e69c0b4b2b55.png">
   
   I think js bundle for notify library is also problematic. We probably should remove the usage and replace with other library. But it's out of scope of this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org