You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Nicolas Poggi (JIRA)" <ji...@apache.org> on 2018/09/15 16:11:00 UTC
[jira] [Comment Edited] (SPARK-25439) [TESTS][SQL] TPCHQuerySuite
customer.c_nationkey should be bigint instead of string
[ https://issues.apache.org/jira/browse/SPARK-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616370#comment-16616370 ]
Nicolas Poggi edited comment on SPARK-25439 at 9/15/18 4:10 PM:
----------------------------------------------------------------
Created the [PR with the patch|https://github.com/apache/spark/pull/22430].
was (Author: npoggi):
Created the[ PR with the patch|[https://github.com/apache/spark/pull/22430].]
> [TESTS][SQL] TPCHQuerySuite customer.c_nationkey should be bigint instead of string
> -----------------------------------------------------------------------------------
>
> Key: SPARK-25439
> URL: https://issues.apache.org/jira/browse/SPARK-25439
> Project: Spark
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 2.3.1
> Reporter: Nicolas Poggi
> Priority: Minor
> Labels: benchmark, easy-fix, test
> Original Estimate: 1h
> Remaining Estimate: 1h
>
>
> The [TPCHQuerySuite|https://github.com/apache/spark/blob/be454a7cef1cb5c76fb22589fc3a55c1bf519cf4/sql/core/src/test/scala/org/apache/spark/sql/TPCHQuerySuite.scala#L72] currently has {{string}} for the {{customer.c_nationkey}} column, while it should be bigint according to [the spec|http://www.tpc.org/TPC_Documents_Current_Versions/pdf/tpc-h_v2.17.3.pdf] (identifier type) and matching the {{nation}} table.
> Note: this update would make previousTPCH results not comparable for queries using the {{customer}} table
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org