You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/18 13:54:01 UTC
[GitHub] [incubator-nuttx] thomasactia opened a new pull request #585:
arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
thomasactia opened a new pull request #585: arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
URL: https://github.com/apache/incubator-nuttx/pull/585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #585:
arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #585: arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
URL: https://github.com/apache/incubator-nuttx/pull/585#issuecomment-600902875
@thomasactia
There is a CI failure from the style check. It wants the comments to be in the same column.
Note : Inserting a blank line resets the col position
Would you please rebase on master (to get the latest nxstyle) or use the following to update it locally to today's nxstyle
```
#/bin/bash
pushd tools
mv nxstyle.c last_nxstyle.c
wget https://raw.githubusercontent.com/apache/incubator-nuttx/master/tools/nxstyle.c
make -f Makefile.host
rm nxstyle.c
mv last_nxstyle.c nxstyle.c
cp nxstyle /usr/local/bin/nxstyle
popd
```
then run tools/checkpatch.sh -f <path to file> and resolve the issues,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #585:
arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #585: arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
URL: https://github.com/apache/incubator-nuttx/pull/585#issuecomment-601176920
> @davids5 Do you prefer to right-shift all comments when there is one block of code for one register, or insert newlines within that block?
Personally I think the original is fine. The tool is the problem here.
@johannes-nivus Do you see a simple way to fix the tool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] thomasactia commented on issue #585:
arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
Posted by GitBox <gi...@apache.org>.
thomasactia commented on issue #585: arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
URL: https://github.com/apache/incubator-nuttx/pull/585#issuecomment-601171138
@davids5 Do you prefer to right-shift all comments when there is one block of code for one register, or insert newlines within that block?
Original:
```
#define USBDEV_ENDPTCTRL_RXE (1 << 7) /* Bit 7: Rx endpoint enable */
#define USBDEV_ENDPTCTRL_RXR (1 << 6) /* Bit 6: Rx data toggle reset */
#define USBDEV_ENDPTCTRL_RXI (1 << 5) /* Bit 5: Rx data toggle inhibit */
#define USBDEV_ENDPTCTRL_RXT_SHIFT (2) /* Bits 2-3: Endpoint type */
#define USBDEV_ENDPTCTRL_RXT_MASK (3 << USBDEV_ENDPTCTRL_RXT_SHIFT)
# define USBDEV_ENDPTCTRL_RXT_CTRL (0 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Control */
# define USBDEV_ENDPTCTRL_RXT_ISOC (1 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Isochronous */
# define USBDEV_ENDPTCTRL_RXT_BULK (2 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Bulk */
```
Insert spaces:
```
#define USBDEV_ENDPTCTRL_RXE (1 << 7) /* Bit 7: Rx endpoint enable */
#define USBDEV_ENDPTCTRL_RXR (1 << 6) /* Bit 6: Rx data toggle reset */
#define USBDEV_ENDPTCTRL_RXI (1 << 5) /* Bit 5: Rx data toggle inhibit */
#define USBDEV_ENDPTCTRL_RXT_SHIFT (2) /* Bits 2-3: Endpoint type */
#define USBDEV_ENDPTCTRL_RXT_MASK (3 << USBDEV_ENDPTCTRL_RXT_SHIFT)
# define USBDEV_ENDPTCTRL_RXT_CTRL (0 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Control */
# define USBDEV_ENDPTCTRL_RXT_ISOC (1 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Isochronous */
# define USBDEV_ENDPTCTRL_RXT_BULK (2 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Bulk */
```
Or split the block:
```#define USBDEV_ENDPTCTRL_RXE (1 << 7) /* Bit 7: Rx endpoint enable */
#define USBDEV_ENDPTCTRL_RXR (1 << 6) /* Bit 6: Rx data toggle reset */
#define USBDEV_ENDPTCTRL_RXI (1 << 5) /* Bit 5: Rx data toggle inhibit */
#define USBDEV_ENDPTCTRL_RXT_SHIFT (2) /* Bits 2-3: Endpoint type */
#define USBDEV_ENDPTCTRL_RXT_MASK (3 << USBDEV_ENDPTCTRL_RXT_SHIFT)
# define USBDEV_ENDPTCTRL_RXT_CTRL (0 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Control */
# define USBDEV_ENDPTCTRL_RXT_ISOC (1 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Isochronous */
# define USBDEV_ENDPTCTRL_RXT_BULK (2 << USBDEV_ENDPTCTRL_RXT_SHIFT) /* Bulk */
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #585:
arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on issue #585: arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
URL: https://github.com/apache/incubator-nuttx/pull/585#issuecomment-601205086
@davids5 please see #591
But I think @patacongo should review that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #585:
arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #585: arch/arm/src/imxrt/imxrt_usbdev.c: Add OUT interrupt endpoint support
URL: https://github.com/apache/incubator-nuttx/pull/585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services