You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2025/05/02 07:17:43 UTC
Re: Review Request 75380: RANGER-5187: Getting 404 instead of 400 when we try to edit user without id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75380/
-----------------------------------------------------------
(Updated May 2, 2025, 7:17 a.m.)
Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-5187
https://issues.apache.org/jira/browse/RANGER-5187
Repository: ranger
Description
-------
After modifying the json payload to update the user, the HTTP response is supposed to be error "400 Bad Request" but we are getting error 404.
This fix restores a minor bug introduced in RANGER-4851. This fix is to read the user object using "id" a line before passing it to the xUserService.getTransactionLog() function.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java f63818c69
Diff: https://reviews.apache.org/r/75380/diff/2/
Changes: https://reviews.apache.org/r/75380/diff/1-2/
Testing
-------
Ranger maven build successful.
Ranger Setup & install successful.
Performed sanity testing. Ensured that the repro scenario yields correct evaluation result.
Thanks,
Mahesh Bandal
Re: Review Request 75380: RANGER-5187: Getting 404 instead of 400 when we try to edit user without id
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75380/#review227315
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 2, 2025, 7:17 a.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75380/
> -----------------------------------------------------------
>
> (Updated May 2, 2025, 7:17 a.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-5187
> https://issues.apache.org/jira/browse/RANGER-5187
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After modifying the json payload to update the user, the HTTP response is supposed to be error "400 Bad Request" but we are getting error 404.
>
> This fix restores a minor bug introduced in RANGER-4851. This fix is to read the user object using "id" a line before passing it to the xUserService.getTransactionLog() function.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java f63818c69
>
>
> Diff: https://reviews.apache.org/r/75380/diff/2/
>
>
> Testing
> -------
>
> Ranger maven build successful.
> Ranger Setup & install successful.
> Performed sanity testing. Ensured that the repro scenario yields correct evaluation result.
>
>
> Thanks,
>
> Mahesh Bandal
>
>