You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/06/03 17:48:51 UTC

[GitHub] [hive] achennagiri commented on a diff in pull request #3341: HIVE-26289: Remove useless try catch in DataWritableReadSupport#getWriterDateProleptic

achennagiri commented on code in PR #3341:
URL: https://github.com/apache/hive/pull/3341#discussion_r889199970


##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/DataWritableReadSupport.java:
##########
@@ -278,15 +278,7 @@ public static Boolean getWriterDateProleptic(Map<String, String> metadata) {
       return null;
     }
     String value = metadata.get(DataWritableWriteSupport.WRITER_DATE_PROLEPTIC);

Review Comment:
   I don't really understand the code fully but it looks like
    `String value = metadata.get(DataWritableWriteSupport.WRITER_DATE_PROLEPTIC);` should have been inside the try catch block right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org