You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rainer Jung <ra...@kippdata.de> on 2013/11/17 12:47:53 UTC
Re: svn commit: r1542615 - /httpd/httpd/trunk/build/config-stubs
Hi Stefan,
On 17.11.2013 00:49, sf@apache.org wrote:
> Author: sf
> Date: Sat Nov 16 23:49:04 2013
> New Revision: 1542615
>
> URL: http://svn.apache.org/r1542615
> Log:
> Explicitly list in which directories to look for config*.m4 files.
>
> If some distributor patches a config*.m4 file with quilt, that will
> place a copy of the original file in .pc/ . Doing a naive "find ."
> will then cause both the original and the patched m4 file to be included,
> causing havoc later on.
>
> PR: 55787
>
> Modified:
> httpd/httpd/trunk/build/config-stubs
>
> Modified: httpd/httpd/trunk/build/config-stubs
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/build/config-stubs?rev=1542615&r1=1542614&r2=1542615&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/build/config-stubs (original)
> +++ httpd/httpd/trunk/build/config-stubs Sat Nov 16 23:49:04 2013
> @@ -15,7 +15,7 @@
> # config files without a number are sorted before those with a number.
> #
>
> -configfiles=`find . -name "config*.m4" | \
> +configfiles=`find os server modules support -name "config*.m4" | \
Couldn't we use
configfiles=`find . -name ".*" -prune -o -name "config*.m4" | \
That would disable recuring into any directory starting with a dot and
thus we wouldn't have to maintain a list of known good directories.
WDYT?
Regards,
Rainer
Re: svn commit: r1542615 - /httpd/httpd/trunk/build/config-stubs
Posted by Rainer Jung <ra...@kippdata.de>.
On 19.11.2013 23:45, Stefan Fritsch wrote:
> Hi Rainer,
>
> Am Sonntag, 17. November 2013, 12:47:53 schrieb Rainer Jung:
>>> URL: http://svn.apache.org/r1542615
>>> Log:
>>> Explicitly list in which directories to look for config*.m4 files.
>>>
>
>
>>> --- httpd/httpd/trunk/build/config-stubs (original)
>>> +++ httpd/httpd/trunk/build/config-stubs Sat Nov 16 23:49:04 2013
>>> @@ -15,7 +15,7 @@
>>>
>>> # config files without a number are sorted before those with a
>>> number. #
>>>
>>> -configfiles=`find . -name "config*.m4" | \
>>> +configfiles=`find os server modules support -name "config*.m4" |
>>> \
>>
>> Couldn't we use
>>
>> configfiles=`find . -name ".*" -prune -o -name "config*.m4" | \
>>
>> That would disable recuring into any directory starting with a dot
>> and thus we wouldn't have to maintain a list of known good
>> directories.
>>
>> WDYT?
>
> I am not convinced that this would be better. If apr or another lib in
> srclib/ one day ships a config*.m4 file, we don't want to include that
> either. Or if debian packagers for whatever reason such a file in
> debian/. And we won't have to update that list very often, the top-
> level directories haven't changed since 1.x.
OK, agreed.
Rainer
Re: svn commit: r1542615 - /httpd/httpd/trunk/build/config-stubs
Posted by Stefan Fritsch <sf...@sfritsch.de>.
Hi Rainer,
Am Sonntag, 17. November 2013, 12:47:53 schrieb Rainer Jung:
> > URL: http://svn.apache.org/r1542615
> > Log:
> > Explicitly list in which directories to look for config*.m4 files.
> >
> > --- httpd/httpd/trunk/build/config-stubs (original)
> > +++ httpd/httpd/trunk/build/config-stubs Sat Nov 16 23:49:04 2013
> > @@ -15,7 +15,7 @@
> >
> > # config files without a number are sorted before those with a
> > number. #
> >
> > -configfiles=`find . -name "config*.m4" | \
> > +configfiles=`find os server modules support -name "config*.m4" |
> > \
>
> Couldn't we use
>
> configfiles=`find . -name ".*" -prune -o -name "config*.m4" | \
>
> That would disable recuring into any directory starting with a dot
> and thus we wouldn't have to maintain a list of known good
> directories.
>
> WDYT?
I am not convinced that this would be better. If apr or another lib in
srclib/ one day ships a config*.m4 file, we don't want to include that
either. Or if debian packagers for whatever reason such a file in
debian/. And we won't have to update that list very often, the top-
level directories haven't changed since 1.x.
Cheers,
Stefan