You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by db...@apache.org on 2015/09/18 03:34:57 UTC
[3/3] docs commit: Made plugin filter buttons fixed width and removed
their delay. This closes #352.
Made plugin filter buttons fixed width and removed their delay. This closes #352.
Project: http://git-wip-us.apache.org/repos/asf/cordova-docs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-docs/commit/578fae27
Tree: http://git-wip-us.apache.org/repos/asf/cordova-docs/tree/578fae27
Diff: http://git-wip-us.apache.org/repos/asf/cordova-docs/diff/578fae27
Branch: refs/heads/cordova-website
Commit: 578fae279a87189b057df0ed165928b2447583fc
Parents: 0d0f2fb
Author: riknoll <ri...@microsoft.com>
Authored: Thu Sep 17 18:21:43 2015 -0700
Committer: Dmitry Blotsky <dm...@gmail.com>
Committed: Thu Sep 17 18:34:28 2015 -0700
----------------------------------------------------------------------
www/static/css-src/_plugins.scss | 4 ++++
www/static/plugins/app.js | 8 +++-----
www/static/plugins/platformbutton.jsx | 16 ++++++----------
3 files changed, 13 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-docs/blob/578fae27/www/static/css-src/_plugins.scss
----------------------------------------------------------------------
diff --git a/www/static/css-src/_plugins.scss b/www/static/css-src/_plugins.scss
index 1ed59db..20602ab 100644
--- a/www/static/css-src/_plugins.scss
+++ b/www/static/css-src/_plugins.scss
@@ -66,6 +66,10 @@
.filter-by-platform-filters {
display: inline-block;
button.btn {
+ margin-bottom: 2px;
+ margin-right: 2px;
+ width: 120px;
+
&.btn-primary {
background-color: $brand-primary;
}
http://git-wip-us.apache.org/repos/asf/cordova-docs/blob/578fae27/www/static/plugins/app.js
----------------------------------------------------------------------
diff --git a/www/static/plugins/app.js b/www/static/plugins/app.js
index 76e0a86..c1a1557 100755
--- a/www/static/plugins/app.js
+++ b/www/static/plugins/app.js
@@ -78,9 +78,7 @@ var App = React.createClass({
previousState.staticFilters[keyword].push(condition);
}
- delay(function(){
- App.updateURL(previousState.filterText, previousState.staticFilters['platforms'], previousState.sortCriteria);
- }, INPUT_DELAY);
+ App.updateURL(previousState.filterText, previousState.staticFilters['platforms'], previousState.sortCriteria);
return {
staticFilters: previousState.staticFilters,
@@ -462,7 +460,7 @@ var App = React.createClass({
<div className="row filter-by-platforms">
<div className="col-sm-9">
<div className="filter-by-platform-label"><span>Must Support Platform(s):</span></div>
- <ul className="nav nav-pills filter-by-platform-filters">
+ <div className="filter-by-platform-filters">
{createPlatformButton("Android", "cordova-android", this.state)}
{createPlatformButton("iOS", "cordova-ios", this.state)}
{createPlatformButton("Windows", "cordova-windows", this.state)}
@@ -472,7 +470,7 @@ var App = React.createClass({
{createPlatformButton("Fire OS", "cordova-amazon-fireos", this.state)}
{createPlatformButton("WP8", "cordova-wp8", this.state)}
{createPlatformButton("Browser", "cordova-browser", this.state)}
- </ul>
+ </div>
</div>
<div className="col-sm-3">
<div className="plugin-results-number">{this.state.searchResults.length} result(s) found</div>
http://git-wip-us.apache.org/repos/asf/cordova-docs/blob/578fae27/www/static/plugins/platformbutton.jsx
----------------------------------------------------------------------
diff --git a/www/static/plugins/platformbutton.jsx b/www/static/plugins/platformbutton.jsx
index 071602d..529e2eb 100755
--- a/www/static/plugins/platformbutton.jsx
+++ b/www/static/plugins/platformbutton.jsx
@@ -18,19 +18,15 @@ var PlatformButton = React.createClass({
render: function() {
if(this.state.isActive) {
return (
- <li role="presentation" className="active" onClick={this.onClick}>
- <button className="btn btn-primary">
- <span className="glyphicon glyphicon-ok"></span><i> </i>{this.props.platform}
- </button>
- </li>
+ <button className="btn btn-primary" onClick={this.onClick}>
+ <span className="glyphicon glyphicon-ok"></span><i> </i>{this.props.platform}
+ </button>
);
} else {
return (
- <li role="presentation" onClick={this.onClick}>
- <button className="btn btn-default">
- {this.props.platform}
- </button>
- </li>
+ <button className="btn btn-default" onClick={this.onClick}>
+ {this.props.platform}
+ </button>
);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org