You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:05:54 UTC

[GitHub] [skywalking] kezhenxu94 opened a new issue, #9727: [Rover] license issue

kezhenxu94 opened a new issue, #9727:
URL: https://github.com/apache/skywalking/issues/9727

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   OAP server (apache/skywalking)
   
   ### What happened
   
   I happened to find the license of the source file [protocol_analyze.h](https://github.com/apache/skywalking-rover/blob/main/bpf/profiling/network/protocol_analyze.h#L19) is GPL-2.0 but [we declare it as Apache 2.0](https://github.com/apache/skywalking-rover/blob/48fb8ced2e4aaf505777c6eac2587d799ab9c2bd/LICENSE#L218), which is not allowed as per ASF’s policy. 
   
   we should fix this as soon as possible before the next release. 
   
   ### What you expected to happen
   
   No license conflict
   
   ### How to reproduce
   
   No need to reproduce. 
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #9727: [Rover] license issue

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9727: [Rover] license issue
URL: https://github.com/apache/skywalking/issues/9727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #9727: [Rover] license issue

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9727:
URL: https://github.com/apache/skywalking/issues/9727#issuecomment-1265606625

   Another thing I found is that this file is not a simple copy of the original file. It adds some other content from other file but doesn't mention the changes and the other files. I'm not sure whether there are other similar cases or not. Please overhaul the files that are copied from other repos. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9727: [Rover] license issue

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9727:
URL: https://github.com/apache/skywalking/issues/9727#issuecomment-1265592174

   @mrproliu As a protocol analyzer, I think it should be very easy to rebuild one, and we just need HTTP 1.1/2 identifying.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org