[GitHub] [iceberg] rdblue commented on pull request #2603: Core: Deal with expired parent snapshot in MergingSnapshotProducer#validateDataFilesExist

[GitBox <gi...@apache.org>]

rdblue commented on pull request #2603:
URL: https://github.com/apache/iceberg/pull/2603#issuecomment-861831900


   @jshmchenxi, see my comments above for more detail, but this approach can't work for the situation you describe. If you want to support this situation, then you would need to scan all table metadata to check whether the files that need to exist still do using added and existing entries, not delete entries. Since delete entries can be lost when history is cleaned up, you have to check for the actual files.
   
   I'm going to close this PR since the approach won't work. Feel free to open another one with an alternative implementation that checks for added or existing entries for the required files.
   
   Thanks for working on this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org