[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #48: [YUNIKORN-885] Set healtch check as liveness probe

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #48:
URL: https://github.com/apache/incubator-yunikorn-release/pull/48#discussion_r734630973



##########
File path: helm-charts/yunikorn/templates/deployment.yaml
##########
@@ -93,6 +93,12 @@ spec:
                 exec:
                   command: ["/bin/sh", "/admission_util.sh", "create"]
           {{ end }}
+          livenessProbe:

Review comment:
       I moved theem to the values.yaml filee, so during installation it can be changed. 
   I set the threashold to 1 instead of 3, to make sure that the restart is triggered if the scheduler is in a bad state. I don't think this is too aggressive. Is better to restart it, than keeping it running in a bad state and maybe causing some unpredicted issues. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org