You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Marco Massenzio (JIRA)" <ji...@apache.org> on 2015/11/20 17:42:11 UTC

[jira] [Assigned] (MESOS-3961) Consider equality behavior for DiskInfo resource

     [ https://issues.apache.org/jira/browse/MESOS-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Massenzio reassigned MESOS-3961:
--------------------------------------

    Assignee: Greg Mann

> Consider equality behavior for DiskInfo resource
> ------------------------------------------------
>
>                 Key: MESOS-3961
>                 URL: https://issues.apache.org/jira/browse/MESOS-3961
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Neil Conway
>            Assignee: Greg Mann
>            Priority: Minor
>              Labels: mesosphere, persistent-volumes
>
> Relevant code:
> {code}
> bool operator==(const Resource::DiskInfo& left, const Resource::DiskInfo& right)
> {
>   // NOTE: We ignore 'volume' inside DiskInfo when doing comparison
>   // because it describes how this resource will be used which has
>   // nothing to do with the Resource object itself. A framework can
>   // use this resource and specify different 'volume' every time it
>   // uses it.
>   if (left.has_persistence() != right.has_persistence()) {
>     return false;
>   }
>   if (left.has_persistence()) {
>     return left.persistence().id() == right.persistence().id();
>   }
>   return true;
> }
> {code}
> A consequence of this behavior is that if you pass the wrong path to a `destroy-volume` request (but there is a persistent volume that otherwise matches the request), the path will be ignored and the volume will be destroyed. Not clear if that is undesirable, but it does seem surprising.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)