[GitHub] [incubator-mxnet] leezu opened a new pull request #17018: Replace mxnet_option macro with standard CMAKE_DEPENDENT_OPTION

[GitBox <gi...@apache.org>]

leezu opened a new pull request #17018: Replace mxnet_option macro with standard CMAKE_DEPENDENT_OPTION
URL: https://github.com/apache/incubator-mxnet/pull/17018
 
 
   ## Description ##
   Replace mxnet_option macro with standard CMAKE_DEPENDENT_OPTION.
   Using standard language constructs improves maintainability and eases reading the code.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Replace mxnet_option macro with CMAKE_DEPENDENT_OPTION part of CMake "standard library"
   
   ## Comments ##
   @cjolivier01 please confirm the change in `FindMKL.cmake` is correct. My understanding is that
   - `MKL_USE_STATIC_LIBS` should always be `OFF`, and the user can only set it to `ON` if `MKL_USE_SINGLE_DYNAMIC_LIBRARY is OFF`.
   -  `MKL_MULTI_THREADED` should always be `ON`, and the user can only set it to `OFF` if `MKL_USE_SINGLE_DYNAMIC_LIBRARY is OFF`.
   -  `MKL_USE_CLUSTER` should always be `OFF`, and the user can only set it to `ON` if `CMAKE_SIZEOF_VOID_P EQUAL 4`.
   
   Previously the variables where undefined when the condition was not true.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services