You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@empire-db.apache.org by "Marcio Mazza (JIRA)" <em...@incubator.apache.org> on 2010/10/06 02:57:32 UTC
[jira] Created: (EMPIREDB-85) Remove declarations of unused
dependencies (from pom.xml)
Remove declarations of unused dependencies (from pom.xml)
----------------------------------------------------------
Key: EMPIREDB-85
URL: https://issues.apache.org/jira/browse/EMPIREDB-85
Project: Empire-DB
Issue Type: Bug
Components: CodeGenerator, Core, Struts2 Extentions
Affects Versions: empire-db-2.0.7-incubating
Reporter: Marcio Mazza
Priority: Trivial
By running "mvn dependency:analyze"
one can detect that there are some declared dependencies (in the pom files) which are not used indeed by the codebase.
Shouldn't they be removed?
Running against
http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared but not used at all.
I see that the mockito dependency comes from the parent, so maybe that should be left alone.
The output of "mvn dependency:analyze" for the core is, in summary:
------------------------------------------------------------------------
Apache Empire-db Core
------------------------------------------------------------------------
[WARNING] Unused declared dependencies found:
[WARNING] commons-collections:commons-collections:jar:3.2.1:compile
[WARNING] org.mockito:mockito-core:jar:1.8.2:test
[WARNING] hsqldb:hsqldb:jar:1.8.0.10:test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (EMPIREDB-85) Remove declarations of unused
dependencies (from pom.xml)
Posted by "Francis De Brabandere (JIRA)" <em...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/EMPIREDB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927211#action_12927211 ]
Francis De Brabandere commented on EMPIREDB-85:
-----------------------------------------------
Hi Marcio,
Thanks for reporting this!
For now I ignored the examples.
Removed commons-collections dependency, as well as some others (see commit)
Mockito and hsqldb are test-scope dependencies which are valid, better to just look at compile-time with this command:
mvn dependency:analyze -DignoreNonCompile
> Remove declarations of unused dependencies (from pom.xml)
> ----------------------------------------------------------
>
> Key: EMPIREDB-85
> URL: https://issues.apache.org/jira/browse/EMPIREDB-85
> Project: Empire-DB
> Issue Type: Bug
> Components: CodeGenerator, Core, Struts2 Extentions
> Affects Versions: empire-db-2.0.6-incubating
> Reporter: Marcio Mazza
> Assignee: Francis De Brabandere
> Priority: Trivial
> Fix For: empire-db-2.0.7-incubating
>
> Attachments: empire-db_summary-of-dependency-analyse.txt
>
>
> By running "mvn dependency:analyze"
> one can detect that there are some declared dependencies (in the pom files) which are not used indeed by the codebase.
> Shouldn't they be removed?
> Running against
> http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared but not used at all.
> I see that the mockito dependency comes from the parent, so maybe that should be left alone.
> The output of "mvn dependency:analyze" for the core is, in summary:
> ------------------------------------------------------------------------
> Apache Empire-db Core
> ------------------------------------------------------------------------
> [WARNING] Unused declared dependencies found:
> [WARNING] commons-collections:commons-collections:jar:3.2.1:compile
> [WARNING] org.mockito:mockito-core:jar:1.8.2:test
> [WARNING] hsqldb:hsqldb:jar:1.8.0.10:test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (EMPIREDB-85) Remove declarations of unused
dependencies (from pom.xml)
Posted by "Marcio Mazza (JIRA)" <em...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/EMPIREDB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcio Mazza updated EMPIREDB-85:
---------------------------------
Attachment: empire-db_summary-of-dependency-analyse.txt
Summary result of running "mvn dependency:analyze"
against http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> Remove declarations of unused dependencies (from pom.xml)
> ----------------------------------------------------------
>
> Key: EMPIREDB-85
> URL: https://issues.apache.org/jira/browse/EMPIREDB-85
> Project: Empire-DB
> Issue Type: Bug
> Components: CodeGenerator, Core, Struts2 Extentions
> Affects Versions: empire-db-2.0.7-incubating
> Reporter: Marcio Mazza
> Priority: Trivial
> Attachments: empire-db_summary-of-dependency-analyse.txt
>
>
> By running "mvn dependency:analyze"
> one can detect that there are some declared dependencies (in the pom files) which are not used indeed by the codebase.
> Shouldn't they be removed?
> Running against
> http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared but not used at all.
> I see that the mockito dependency comes from the parent, so maybe that should be left alone.
> The output of "mvn dependency:analyze" for the core is, in summary:
> ------------------------------------------------------------------------
> Apache Empire-db Core
> ------------------------------------------------------------------------
> [WARNING] Unused declared dependencies found:
> [WARNING] commons-collections:commons-collections:jar:3.2.1:compile
> [WARNING] org.mockito:mockito-core:jar:1.8.2:test
> [WARNING] hsqldb:hsqldb:jar:1.8.0.10:test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (EMPIREDB-85) Remove declarations of unused
dependencies (from pom.xml)
Posted by "Francis De Brabandere (JIRA)" <em...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/EMPIREDB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis De Brabandere reassigned EMPIREDB-85:
---------------------------------------------
Assignee: Francis De Brabandere
> Remove declarations of unused dependencies (from pom.xml)
> ----------------------------------------------------------
>
> Key: EMPIREDB-85
> URL: https://issues.apache.org/jira/browse/EMPIREDB-85
> Project: Empire-DB
> Issue Type: Bug
> Components: CodeGenerator, Core, Struts2 Extentions
> Affects Versions: empire-db-2.0.6-incubating
> Reporter: Marcio Mazza
> Assignee: Francis De Brabandere
> Priority: Trivial
> Fix For: empire-db-2.0.7-incubating
>
> Attachments: empire-db_summary-of-dependency-analyse.txt
>
>
> By running "mvn dependency:analyze"
> one can detect that there are some declared dependencies (in the pom files) which are not used indeed by the codebase.
> Shouldn't they be removed?
> Running against
> http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared but not used at all.
> I see that the mockito dependency comes from the parent, so maybe that should be left alone.
> The output of "mvn dependency:analyze" for the core is, in summary:
> ------------------------------------------------------------------------
> Apache Empire-db Core
> ------------------------------------------------------------------------
> [WARNING] Unused declared dependencies found:
> [WARNING] commons-collections:commons-collections:jar:3.2.1:compile
> [WARNING] org.mockito:mockito-core:jar:1.8.2:test
> [WARNING] hsqldb:hsqldb:jar:1.8.0.10:test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (EMPIREDB-85) Remove declarations of unused
dependencies (from pom.xml)
Posted by "Francis De Brabandere (JIRA)" <em...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/EMPIREDB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis De Brabandere updated EMPIREDB-85:
------------------------------------------
Affects Version/s: (was: empire-db-2.0.7-incubating )
empire-db-2.0.6-incubating
Fix Version/s: empire-db-2.0.7-incubating
> Remove declarations of unused dependencies (from pom.xml)
> ----------------------------------------------------------
>
> Key: EMPIREDB-85
> URL: https://issues.apache.org/jira/browse/EMPIREDB-85
> Project: Empire-DB
> Issue Type: Bug
> Components: CodeGenerator, Core, Struts2 Extentions
> Affects Versions: empire-db-2.0.6-incubating
> Reporter: Marcio Mazza
> Priority: Trivial
> Fix For: empire-db-2.0.7-incubating
>
> Attachments: empire-db_summary-of-dependency-analyse.txt
>
>
> By running "mvn dependency:analyze"
> one can detect that there are some declared dependencies (in the pom files) which are not used indeed by the codebase.
> Shouldn't they be removed?
> Running against
> http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared but not used at all.
> I see that the mockito dependency comes from the parent, so maybe that should be left alone.
> The output of "mvn dependency:analyze" for the core is, in summary:
> ------------------------------------------------------------------------
> Apache Empire-db Core
> ------------------------------------------------------------------------
> [WARNING] Unused declared dependencies found:
> [WARNING] commons-collections:commons-collections:jar:3.2.1:compile
> [WARNING] org.mockito:mockito-core:jar:1.8.2:test
> [WARNING] hsqldb:hsqldb:jar:1.8.0.10:test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (EMPIREDB-85) Remove declarations of unused
dependencies (from pom.xml)
Posted by "Francis De Brabandere (JIRA)" <em...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/EMPIREDB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis De Brabandere resolved EMPIREDB-85.
-------------------------------------------
Resolution: Fixed
Cleaned up most important unneeded dependencies (ignoring examples)
> Remove declarations of unused dependencies (from pom.xml)
> ----------------------------------------------------------
>
> Key: EMPIREDB-85
> URL: https://issues.apache.org/jira/browse/EMPIREDB-85
> Project: Empire-DB
> Issue Type: Bug
> Components: CodeGenerator, Core, Struts2 Extentions
> Affects Versions: empire-db-2.0.6-incubating
> Reporter: Marcio Mazza
> Assignee: Francis De Brabandere
> Priority: Trivial
> Fix For: empire-db-2.0.7-incubating
>
> Attachments: empire-db_summary-of-dependency-analyse.txt
>
>
> By running "mvn dependency:analyze"
> one can detect that there are some declared dependencies (in the pom files) which are not used indeed by the codebase.
> Shouldn't they be removed?
> Running against
> http://svn.apache.org/repos/asf/incubator/empire-db/trunk@992776
> e.g., for the CORE we see that commons-collections, mockito and hsqldb were declared but not used at all.
> I see that the mockito dependency comes from the parent, so maybe that should be left alone.
> The output of "mvn dependency:analyze" for the core is, in summary:
> ------------------------------------------------------------------------
> Apache Empire-db Core
> ------------------------------------------------------------------------
> [WARNING] Unused declared dependencies found:
> [WARNING] commons-collections:commons-collections:jar:3.2.1:compile
> [WARNING] org.mockito:mockito-core:jar:1.8.2:test
> [WARNING] hsqldb:hsqldb:jar:1.8.0.10:test
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.