[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2322: [Improve][Connector-V2] Http connector v2 source improve

[GitBox <gi...@apache.org>]

CalvinKirs commented on code in PR #2322:
URL: https://github.com/apache/incubator-seatunnel/pull/2322#discussion_r935070260


##########
seatunnel-connectors-v2/connector-http/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSource.java:
##########
@@ -39,23 +32,22 @@
 import org.apache.seatunnel.connectors.seatunnel.common.source.AbstractSingleSplitReader;
 import org.apache.seatunnel.connectors.seatunnel.common.source.AbstractSingleSplitSource;
 import org.apache.seatunnel.connectors.seatunnel.common.source.SingleSplitReaderContext;
+import org.apache.seatunnel.connectors.seatunnel.http.config.HttpConfig;
+import org.apache.seatunnel.connectors.seatunnel.http.config.HttpParameter;
 
 import org.apache.seatunnel.shade.com.typesafe.config.Config;
 
 import com.google.auto.service.AutoService;
 
-import java.util.Map;
-import java.util.stream.Collectors;
-
 @AutoService(SeaTunnelSource.class)
 public class HttpSource extends AbstractSingleSplitSource<SeaTunnelRow> {
-    private final HttpSourceParameter parameter = new HttpSourceParameter();
+    private final HttpParameter httpParameter = new HttpParameter();
     private SeaTunnelRowType rowType;
     private SeaTunnelContext seaTunnelContext;
 
     @Override
     public String getPluginName() {
-        return "Http";
+        return "HttpSource";

Review Comment:
   I think to keep `HTTP` it's better, We don't need too much redundant context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org