You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/03 01:15:32 UTC
Review Request 28616: Removed the empty resource check in master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28616/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2167
https://issues.apache.org/jira/browse/MESOS-2167
Repository: mesos-git
Description
-------
Removed the empty resource check in master.
Diffs
-----
src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d
src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2
Diff: https://reviews.apache.org/r/28616/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 28616: Removed the empty resource check in master.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28616/#review63616
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28616]
All tests passed.
- Mesos ReviewBot
On Dec. 3, 2014, 12:15 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28616/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 12:15 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2167
> https://issues.apache.org/jira/browse/MESOS-2167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Removed the empty resource check in master.
>
>
> Diffs
> -----
>
> src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d
> src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2
>
> Diff: https://reviews.apache.org/r/28616/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28616: Removed the empty resource check in master.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 3, 2014, 1:24 a.m., Ben Mahler wrote:
> > src/master/master.cpp, line 1930
> > <https://reviews.apache.org/r/28616/diff/1/?file=780506#file780506line1930>
> >
> > Is this TODO still needed? Looks like we'll send back the message now, which I assume will reference the name of the invalid resource?
Removed.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28616/#review63621
-----------------------------------------------------------
On Dec. 3, 2014, 12:15 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28616/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 12:15 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2167
> https://issues.apache.org/jira/browse/MESOS-2167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Removed the empty resource check in master.
>
>
> Diffs
> -----
>
> src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d
> src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2
>
> Diff: https://reviews.apache.org/r/28616/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28616: Removed the empty resource check in master.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28616/#review63621
-----------------------------------------------------------
Ship it!
Thanks Jie!
src/master/master.cpp
<https://reviews.apache.org/r/28616/#comment105904>
Is this TODO still needed? Looks like we'll send back the message now, which I assume will reference the name of the invalid resource?
- Ben Mahler
On Dec. 3, 2014, 12:15 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28616/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 12:15 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2167
> https://issues.apache.org/jira/browse/MESOS-2167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Removed the empty resource check in master.
>
>
> Diffs
> -----
>
> src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d
> src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2
>
> Diff: https://reviews.apache.org/r/28616/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>