You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/19 04:21:39 UTC
[GitHub] [doris] SharpRay opened a new pull request, #13467: modify LABEL_REGEX, COMMON_NAME_REGIEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX values in FeNameFormat class to support unicode names
SharpRay opened a new pull request, #13467:
URL: https://github.com/apache/doris/pull/13467
modify LABEL_REGEX, COMMON_NAME_REGIEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX values in FeNameFormat class to support unicode names
# Proposed changes
## Problem summary
Made some modifications on regular expression values including LABEL_REGEX, COMMON_NAME_REGEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX defined in FeNameFormat class so as to support Unicode.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13467: modify LABEL_REGEX, COMMON_NAME_REGIEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX values in FeNameFormat class to support unicode names
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13467:
URL: https://github.com/apache/doris/pull/13467#issuecomment-1284763539
Could you please add some regression test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #13467: [enhancement](unicode-support) modify LABEL_REGEX, COMMON_NAME_REGIEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX values in FeNameFormat class to support unicode names
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13467: [enhancement](unicode-support) modify LABEL_REGEX, COMMON_NAME_REGIEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX values in FeNameFormat class to support unicode names
URL: https://github.com/apache/doris/pull/13467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13467: [enhancement](unicode-support) modify LABEL_REGEX, COMMON_NAME_REGIEX, COMMON_TABLE_NAME_REGEX and COLUMN_NAME_REGEX values in FeNameFormat class to support unicode names
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13467:
URL: https://github.com/apache/doris/pull/13467#issuecomment-1519203843
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org