You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/21 13:47:14 UTC

[GitHub] [spark] cloud-fan commented on pull request #32995: [SPARK-35839][SQL] New SQL function: to_timestamp_ntz

cloud-fan commented on pull request #32995:
URL: https://github.com/apache/spark/pull/32995#issuecomment-865046653


   2 high-level comments:
   1. I think this new function should just go with the non-legacy behavior if the legacy conf is enabled, instead of failing.
   2. We can make `ToTimestamp` more general to support this new function, instead of adding a new subclass of `ToTimestamp`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org