[jira] [Commented] (GEODE-3799) Create plugin system for specifying where a backup is stored

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284358#comment-16284358 ] 

ASF GitHub Bot commented on GEODE-3799:
---------------------------------------

dschneider-pivotal commented on a change in pull request #1109: GEODE-3799: Move backups towards a pluggable architecture
URL: https://github.com/apache/geode/pull/1109#discussion_r155890315
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupDestination.java
 ##########
 @@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.backup;
+
+import java.io.IOException;
+
+public interface BackupDestination {
+  String USER_FILES_DIRECTORY = "user";
 
 Review comment:
   Why does the BackupDestination interface have all these String constants? They seem like an implementation details that someone implementing this interface would not care about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create plugin system for specifying where a backup is stored
> ------------------------------------------------------------
>
>                 Key: GEODE-3799
>                 URL: https://issues.apache.org/jira/browse/GEODE-3799
>             Project: Geode
>          Issue Type: Sub-task
>          Components: persistence
>            Reporter: Nick Reich
>            Assignee: Nick Reich
>
> The current logic merges the moving/copying of files with the determining of what to backup. To make it possible to store a backup in cloud storage or other locations, we need to separate these concerns, putting the variable, location-based logic, into a plugin architecture.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)