You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/01 18:51:57 UTC
[GitHub] [airflow] rafyzg opened a new pull request #10095: add typing coverage to mysql providers package
rafyzg opened a new pull request #10095:
URL: https://github.com/apache/airflow/pull/10095
related: #9708
Adding typing annotations to mysql providers package.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10095: Add typing coverage to mysql providers package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10095:
URL: https://github.com/apache/airflow/pull/10095#issuecomment-668736243
Just one static check to fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10095: Add typing coverage to mysql providers package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10095:
URL: https://github.com/apache/airflow/pull/10095#issuecomment-675398418
Thanks @rafyzg ! What's next :) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10095: Add typing coverage to mysql providers package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10095:
URL: https://github.com/apache/airflow/pull/10095#issuecomment-673689486
Stil a static code check :(. I really recomend using pre-commits. They save a ton of iteration overhead :) (see STATIC_CHECKS.rst)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10095: Add typing coverage to mysql providers package
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10095:
URL: https://github.com/apache/airflow/pull/10095#discussion_r464035103
##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -182,7 +184,7 @@ def bulk_dump(self, table, tmp_file):
conn.commit()
@staticmethod
- def _serialize_cell(cell, conn): # pylint: disable=signature-differs
+ def _serialize_cell(cell: object, conn: Connection) -> object: # pylint: disable=signature-differs
Review comment:
Maybe we can also match the signatures. I believe the "signature-differs" pylint exception can be removed by adding = None for conn parameter. Which is no harm at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10095: Add typing coverage to mysql providers package
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10095:
URL: https://github.com/apache/airflow/pull/10095#issuecomment-667652104
@rafyzg can you please take a look at CI static checks errors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10095: Add typing coverage to mysql providers package
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10095:
URL: https://github.com/apache/airflow/pull/10095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org