You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Debasish Das <de...@gmail.com> on 2014/05/02 06:11:29 UTC

Re: [GitHub] spark pull request: [SPARK-1157][MLlib] Bug fix: lossHistory shoul...

Please remove it....there is no stochastic bfgs....we will put an admm
wrapper over bfgs which has better optimization properties than sgd....
 On Apr 28, 2014 10:34 PM, "mengxr" <gi...@git.apache.org> wrote:

> Github user mengxr commented on the pull request:
>
>     https://github.com/apache/spark/pull/582#issuecomment-41643015
>
>     I think it is good to remove `miniBatchFraction` from `LBFGS`'s params
> in this PR, unless someone has a good understanding of the behavior of
> "stochastic" L-BFGS.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>