You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@annotator.apache.org by ge...@apache.org on 2020/10/13 20:59:37 UTC
[incubator-annotator] 02/05: Fix type errors
This is an automated email from the ASF dual-hosted git repository.
gerben pushed a commit to branch import-dom-seek
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git
commit 1264ba5cfaaa696147fc161504585602aeda06e0
Author: Gerben <ge...@treora.com>
AuthorDate: Fri Oct 9 21:11:51 2020 +0200
Fix type errors
---
packages/dom/src/seek.ts | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/packages/dom/src/seek.ts b/packages/dom/src/seek.ts
index dc547da..171f3a1 100644
--- a/packages/dom/src/seek.ts
+++ b/packages/dom/src/seek.ts
@@ -9,7 +9,7 @@ const TEXT_NODE = 3
export default function seek(iter: NodeIterator, where: number | Text): number {
if (iter.whatToShow !== SHOW_TEXT) {
- let error
+ let error: Error & { code?: number }
// istanbul ignore next
try {
@@ -25,7 +25,7 @@ export default function seek(iter: NodeIterator, where: number | Text): number {
}
let count = 0
- let node = iter.referenceNode
+ let node: Node | null = iter.referenceNode
let predicates = null
if (isInteger(where)) {
@@ -48,7 +48,7 @@ export default function seek(iter: NodeIterator, where: number | Text): number {
throw new RangeError(E_END)
}
- count += node.nodeValue.length
+ count += (node as Text).data.length
}
if (iter.nextNode()) {
@@ -62,7 +62,7 @@ export default function seek(iter: NodeIterator, where: number | Text): number {
throw new RangeError(E_END)
}
- count -= node.nodeValue.length
+ count -= (node as Text).data.length
}
if (!isText(iter.referenceNode)) {
@@ -73,17 +73,17 @@ export default function seek(iter: NodeIterator, where: number | Text): number {
}
-function isInteger(n) {
+function isInteger(n: any): n is number {
if (typeof n !== 'number') return false;
return isFinite(n) && Math.floor(n) === n;
}
-function isText(node) {
+function isText(node: Node): node is Text {
return node.nodeType === TEXT_NODE
}
-function before(ref, node) {
- return ref.compareDocumentPosition(node) & DOCUMENT_POSITION_PRECEDING
+function before(ref: Node, node: Node): boolean {
+ return !!(ref.compareDocumentPosition(node) & DOCUMENT_POSITION_PRECEDING)
}