[jira] [Commented] (CLOUDSTACK-8616) Redundant VPC with both routers as Master

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363478#comment-16363478 ] 

ASF GitHub Bot commented on CLOUDSTACK-8616:
--------------------------------------------

jayakarteek commented on a change in pull request #587: CLOUDSTACK-8616: Redundant VPC with both routers as Master
URL: https://github.com/apache/cloudstack/pull/587#discussion_r168075787
 
 

 ##########
 File path: systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ
 ##########
 @@ -22,11 +22,11 @@ STRIKE_FILE="$ROUTER_BIN_PATH/keepalived.strikes"
 
 if [ -e $ROUTER_BIN_PATH/keepalived.ts2 ]
 then
-    lasttime=$(cat $ROUTER_BIN_PATH/keepalived.ts2)
     thistime=$(cat $ROUTER_BIN_PATH/keepalived.ts)
-    diff=$(($thistime - $lasttime))
+    lasttime=$(cat $ROUTER_BIN_PATH/keepalived.ts2)
+    diff=$(($lasttime - $thistime))
     s=0
-    if [ $diff -lt 30 ]
 
 Review comment:
   @wilderrodrigues  why there is a change in time comparison logic.
   if condition will never be true with the changes last-time will be less then this-time and diff will be negative.
   So this will end up filling the logs in else condition

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Redundant VPC with both routers as Master
> -----------------------------------------
>
>                 Key: CLOUDSTACK-8616
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8616
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>            Priority: Major
>
> There is an intermittent problem with the keepalived on the redundant VPC routers. Sometimes both routers stay on Master state for a while.
> We are able to reproduce it only when testing with Marvin, which executes the calls very quick. When using the UI and following the same steps, it doesn't happen.
> Setting up:
> 1. Create a VPC using redundant VPC offering
> 2. Add 2 Tiers
> 3. Create 2 VMs in each Tier
> 4. Create ACLs to allow traffic on port 22 coming from 0.0.0.0/0
> 5. Acquire 4 public IPs
> 6. Create Port Forwarding rules - per IP - for port 22
> 7. Assign each PF created to one of the VMs
> 8. SSH to the VMs
> Testing fail over:
> 1. Stop the Master Router
> 2. Check the the Backup Router became Master
> 3. SSH to the VMs 
> Testing failure:
> 1. Delete all port forwarding rules
> 2. SSH to the VMs 
> 3. Verify that it no longer works
> Test recovering
> 1. Restart the router
> 2. Once the router is running, check that it's on Backup state
> 3. Add the port forwarding rules back
> 4. Verify that the routers are still on the same state: 1 Master and 1 Backup
>     - That's the part when it fails during the Marvin tests
>     - When 2 routers are on Master, by restarting 1 router will bring everything to a normal state: 1 master and 1 backup
> 5. SSH to the VMs 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)