You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/13 08:39:02 UTC
[GitHub] [incubator-nuttx] jlaitine opened a new pull request #5215: drivers/mmcsd/sdio.c: Fix struct packing of sdio_resp_r5
jlaitine opened a new pull request #5215:
URL: https://github.com/apache/incubator-nuttx/pull/5215
The struct memeber should be packed as well
Signed-off-by: Jukka Laitinen <ju...@ssrc.tii.ae>
## Summary
Fix an error on a 64-bit RISC-V board, which aligns the structure in a way that it becomes larger than intended
## Impact
## Testing
Tested on Microchip Polarfire SOC FPGA "Icicle" board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5215: drivers/mmcsd/sdio.c: Fix struct packing of sdio_resp_r5
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5215:
URL: https://github.com/apache/incubator-nuttx/pull/5215#discussion_r783785550
##########
File path: drivers/mmcsd/sdio.c
##########
@@ -75,7 +75,7 @@ begin_packed_struct struct sdio_resp_r5
uint32_t io_current_state : 2;
uint32_t illegal_command : 1;
uint32_t com_crc_error : 1;
- } flags;
+ } end_packed_struct flags;
Review comment:
should we move to the next line to avoid the nxstyle warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #5215: drivers/mmcsd/sdio.c: Fix struct packing of sdio_resp_r5
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5215:
URL: https://github.com/apache/incubator-nuttx/pull/5215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5215: drivers/mmcsd/sdio.c: Fix struct packing of sdio_resp_r5
Posted by GitBox <gi...@apache.org>.
jlaitine commented on a change in pull request #5215:
URL: https://github.com/apache/incubator-nuttx/pull/5215#discussion_r783817503
##########
File path: drivers/mmcsd/sdio.c
##########
@@ -75,7 +75,7 @@ begin_packed_struct struct sdio_resp_r5
uint32_t io_current_state : 2;
uint32_t illegal_command : 1;
uint32_t com_crc_error : 1;
- } flags;
+ } end_packed_struct flags;
Review comment:
Yes, sorry about forgetting the nxstyle. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org