You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2015/06/23 16:37:00 UTC

[jira] [Updated] (LUCENE-6573) make all of lucene modules lucene-contrib.jar in 6.0

     [ https://issues.apache.org/jira/browse/LUCENE-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand updated LUCENE-6573:
---------------------------------
    Attachment: LUCENE-6573.patch

Having all modules separated is very valuable, I think we should keep them separated. The only notable exception is Solr since Solr integrates all functionality together on purpose. Maybe we could add a scary warning to the build.xml to discourage adding more dependencies between modules (example attached).

I looked at recent changes to our build.xml files, and it seems to me like the only recent change was LUCENE-6445 which added a dependency from lucene/highlighter to lucene/analysis. [~dsmiley] Do you think you could remove the dependency from lucene/highlighter to lucene/analysis that was added in LUCENE-6445.

> make all of lucene modules lucene-contrib.jar in 6.0
> ----------------------------------------------------
>
>                 Key: LUCENE-6573
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6573
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6573.patch
>
>
> When we added modules, there was a big effort to make sure that there was not stupid dependencies between them. I remember spending a lot of time adding components like MockAnalyzer and switching all tests over to them so that this could be successful.
> Despite that work, people just CANT RESIST DOING THIS but it makes things impossible to use. So I'd rather just make a big lucene-contrib.jar, since folks are unable to be mature about it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org