[GitHub] [kafka] vvcephei commented on pull request #8580: KAFKA-9832: fix attempt to commit non-running tasks

[GitBox <gi...@apache.org>]

vvcephei commented on pull request #8580:
URL: https://github.com/apache/kafka/pull/8580#issuecomment-620962357


   Hey @mjsax , do you have time for a quick review?
   
   This bug seems to have been introduced by https://github.com/apache/kafka/pull/8440/files#r407722022 , which attempts to commit all non-corrupted tasks. Some of these tasks may not be running. The Task implementations will throw an exception if we attempt to `prepareCommit` while not in state RUNNING (or RESTORING).
   
   We could make the task more permissive, so that it would ignore the commit to a task that is not in a committable state. I opted instead to filter out only the tasks in committable states, though. I was concerned that if we make prepareCommit more permissive, we might just complicate the rest of the commit lifecycle, because then the rest of it would also have to be permissive, etc.
   
   Thanks for the very nice test in your prior PR; it was easy to extend it to cover this case and also to add the regression test.
   
   WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org