[jira] [Commented] (FLINK-10354) Savepoints should be counted as retained checkpoints

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617458#comment-16617458 ] 

ASF GitHub Bot commented on FLINK-10354:
----------------------------------------

dawidwys opened a new pull request #6704: [FLINK-10354] Revert "[FLINK-6328] [chkPts] Don't add savepoints to CompletedCheckpointStore"
URL: https://github.com/apache/flink/pull/6704
 
 
   ## What is the purpose of the change
   
   This reverts commit 6f570e7b6810e1645a4f7094f17ab9e8559fa139. 
   
   Savepoints are once again counted as checkpoint, so that if failure happens between savepoint and next checkpoint, side effects on exactly one sinks manifested during savepoint, are taken into account.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Savepoints should be counted as retained checkpoints
> ----------------------------------------------------
>
>                 Key: FLINK-10354
>                 URL: https://issues.apache.org/jira/browse/FLINK-10354
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> This task is about reverting [FLINK-6328].
> The problem is that you can get incorrect results with exactly-once sinks if there is a failure after taking a savepoint but before taking the next checkpoint because the savepoint will also have manifested side effects to the sink.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)