You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/08/05 01:14:41 UTC

[GitHub] [incubator-ratis] runzhiwang opened a new pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

runzhiwang opened a new pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166


   ## What changes were proposed in this pull request?
   `randomized.getDuration()` got from the following code, i.e. `rounded`. `multiplier` is a double value less than 1.5 in the test, such as 1.4999999, `duration` is 1000, then `product` will be 1499.9999, so `rounded` will be 1500, which is not less than `d*1.5`, i.e. 1500.
   
   ![image](https://user-images.githubusercontent.com/51938049/89360621-99947480-d6fb-11ea-8bcd-8f072f66780d.png)
   
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-1021
   
   ## How was this patch tested?
   
   No need to add ut.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] bshashikant merged pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166#issuecomment-668914373


   @bshashikant @lokeshj1703 Could you help review this patch ? Thank you very much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166#issuecomment-669307292


   Hello! Can you tell me what is UT for Ratis? Is it integration tests tool? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] bshashikant commented on pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166#issuecomment-668981073


   Thanks @runzhiwang for the contribution. I have committed this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #166: RATIS-1021. Fix failed UT: testMultipleLinearRandomRetry

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #166:
URL: https://github.com/apache/incubator-ratis/pull/166#issuecomment-669750024


   I just realized UT means unit tests :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org