You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Erick Erickson (Jira)" <ji...@apache.org> on 2020/07/02 16:46:00 UTC
[jira] [Resolved] (SOLR-13308) Move SystemPropertiesRestoreRule to
SolrTestCase
[ https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved SOLR-13308.
-----------------------------------
Resolution: Fixed
Chris:
You nailed it, I didn't understand how "around" works
I wasn't clear about Before/AfterClass I was thinking of adding a check in SolrTestCase to verify that the system vars were the same before as after as an alternative to a rule. I vastly prefer the rule, but was just thinking of possibilities if the Rule wasn't viable for some reason.
So I'll just resolve this as done. I suppose theoretically we could now go through all the tests that have SolrTestCase in their ancestry and remove all the clearing/resetting for sysvars, but frankly I don't see enough tangible benefit to bother.
[~dweiss] Thanks, what Chris put in allows us to not have to remember either one ;)
> Move SystemPropertiesRestoreRule to SolrTestCase
> ------------------------------------------------
>
> Key: SOLR-13308
> URL: https://issues.apache.org/jira/browse/SOLR-13308
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 8.1, master (9.0)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> [~krisden] just traced flaky HDFS tests to not clearing sysprops, see the discussion at SOLR-13297.
> Part of SOLR-13268 is to derive all Solr test classes from SolrTestCase.
> Once that's pushed, does it make sense to put that rule in SolrTestCase so it gets performed automagically so this kind of error doesn't creep back in?
> I don't know the details of how that rule is implemented or whether this makes sense at that level but wanted to discuss.
> I've assigned it to myself, but that's just so I don't lose track of it, but anyone else who wants to pick it up please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org