You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/12 13:42:57 UTC
[GitHub] [tomcat-jakartaee-migration] smarkwal opened a new pull request #2:
Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to
Jakarta
smarkwal opened a new pull request #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2
The following Java packages have not been migrated to the new Jakarta workspace:
- javax.annotation.processing (part of module [java.compiler](https://docs.oracle.com/en/java/javase/14/docs/api/java.compiler/module-summary.html))
- javax.transation.xa (module [java.transaction.xa](https://docs.oracle.com/en/java/javase/14/docs/api/java.transaction.xa/module-summary.html))
Classes from these packages are still part of the JDK - even in Java 11 and greater. They have not been migrated to jakarta.* packages.
The current pattern for EESpecProfile.TOMCAT does not take this into account. As a result, the migration tool has renames classes from these packages. Java classes with dependencies on these packages then have cause NoClassDefFoundErrors.
Even Tomcat 10.0.0-M4 makes use of these Java packages (in their original javax.* namespace).
ecj-4.15.jar has dependencies on ...
- javax.annotation.processing.Filer
- javax.annotation.processing.FilerException
- javax.annotation.processing.Messager
- javax.annotation.processing.ProcessingEnvironment
- javax.annotation.processing.Processor
- javax.annotation.processing.RoundEnvironment
tomcat-dbcp.jar has dependencies on ...
- javax.transaction.xa.XAException
- javax.transaction.xa.XAResource
- javax.transaction.xa.Xid
This pull request fixes this issue by adding to "negative lookahead" sequences into the regex pattern for the Tomcat migration profile.
PS: I'm not a Java/Jakarta EE expert, but I guess that the same fix should be applied to the EE migration profile?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ebourg commented on issue #2: Bugfix:
EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
Posted by GitBox <gi...@apache.org>.
ebourg commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-613008805
Fix rebased and applied. I've also modified the regexp for the EE profile. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ebourg closed pull request #2: Bugfix:
EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
Posted by GitBox <gi...@apache.org>.
ebourg closed pull request #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #2:
Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to
Jakarta
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-613389085
We discussed issue handling for this on the Tomcat dev@ list but never reached a firm conclusion. I'm going to enable GitHub issues as an experiment. Be aware that they might be disabled again if things don't work out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ebourg commented on issue #2: Bugfix:
EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
Posted by GitBox <gi...@apache.org>.
ebourg commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-612998552
Thank you for the fix Stephan. The pull requests are very welcome but we use Bugzilla for the issue tracking: https://bz.apache.org/bugzilla/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] smarkwal commented on issue #2:
Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to
Jakarta
Posted by GitBox <gi...@apache.org>.
smarkwal commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-612616793
PS 2: It would be nice if you could enable the issue tracker on this project. I have another bug I would like to report, but I don't know exactly how to solve it. This is why I cannot submit a pull request. But you maybe have an idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [GitHub] [tomcat-jakartaee-migration] smarkwal commented on issue
#2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to
Jakarta
Posted by Mark Thomas <ma...@apache.org>.
On 14/04/2020 11:31, GitBox wrote:
> smarkwal commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
> URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-613359307
>
>
> Do you have a hint for me on the product (Tomcat 10?) and component I should use in Bugzilla when reporting a bug for this migration tool? (Sorry for abusing this PR for such communication :-/)
We discussed enabling GitHub issues as an experiment for this project.
We didn't reach a decision but I don;t recall any outright objections so
I am going to go ahead and do that for this project so we can see how we
get on with that approach. If it doesn't work, we can disable it again.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] smarkwal commented on issue #2:
Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to
Jakarta
Posted by GitBox <gi...@apache.org>.
smarkwal commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-613359307
Do you have a hint for me on the product (Tomcat 10?) and component I should use in Bugzilla when reporting a bug for this migration tool? (Sorry for abusing this PR for such communication :-/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] smarkwal commented on issue #2:
Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to
Jakarta
Posted by GitBox <gi...@apache.org>.
smarkwal commented on issue #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2#issuecomment-612617299
Visualization of the new regex:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org