You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2023/08/12 00:26:29 UTC
[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #251: Make utf-8 the default character encoding
swebb2066 opened a new pull request, #251:
URL: https://github.com/apache/logging-log4cxx/pull/251
The current default "locale" is not useful as it actually reverts to "US-ASCII" which write a '?' for any non-ascii character.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 merged pull request #251: Make utf-8 the default character encoding
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #251:
URL: https://github.com/apache/logging-log4cxx/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 commented on pull request #251: Make utf-8 the default character encoding
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on PR #251:
URL: https://github.com/apache/logging-log4cxx/pull/251#issuecomment-1676706998
While the encoder can be specified in the appender configuration, the examples in the documentation do not include tht option.
Sending a JSONLayout or an XMLLayout to a file or socket in anything other than UTF-8 would not be good, and UTF-8 is an expected default for .txt files.
Hence I conclude that changing the default encoding to UTF-8 is important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #251: Make utf-8 the default character encoding
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on PR #251:
URL: https://github.com/apache/logging-log4cxx/pull/251#issuecomment-1675905303
If you're getting ? characters, you may just need to set your locale(see FAQ: https://logging.apache.org/log4cxx/latest_stable/faq.html#unicode_supported)
I'm not sure if this changes that in any bad way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 commented on pull request #251: Make utf-8 the default character encoding
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on PR #251:
URL: https://github.com/apache/logging-log4cxx/pull/251#issuecomment-1676149445
Unfortunately, the LocaleCharsetEncoder implementation has never worked. The names reported by `apr_os_locale_encoding` do not correspond to the names recognised by `CharsetEncoder::getEncoder()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 commented on pull request #251: Make utf-8 the default character encoding
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on PR #251:
URL: https://github.com/apache/logging-log4cxx/pull/251#issuecomment-1676691831
With the LocaleCharsetEncoder now fixed, the change to UTF-8 as the default would only be justified if UTF-8 is a better default for log files, which I suspect is the case.
@rm5248 do you know what log file encode aggregation services usually expect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org