You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/30 22:16:03 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8325: [fix]
omit datasources with null name or id
codecov-io commented on issue #8325: [fix] omit datasources with null name or id
URL: https://github.com/apache/incubator-superset/pull/8325#issuecomment-536774965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=h1) Report
> Merging [#8325](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cff10ebfcbeaa374a323b866fda49730f3bb1dd4?src=pr&el=desc) will **decrease** coverage by `5.73%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8325/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8325 +/- ##
==========================================
- Coverage 73.48% 67.75% -5.74%
==========================================
Files 115 451 +336
Lines 12399 22702 +10303
Branches 0 2370 +2370
==========================================
+ Hits 9112 15381 +6269
- Misses 3287 7184 +3897
- Partials 0 137 +137
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.06% <ø> (ø)` | :arrow_up: |
| [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | `50% <0%> (ø)` | |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
| [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | `0% <0%> (ø)` | |
| [...ts/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDb21wb25lbnRXaWR0aEZyb21Ecm9wLmpz) | `95.23% <0%> (ø)` | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `2.46% <0%> (ø)` | |
| [superset/assets/src/welcome/DashboardTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0Rhc2hib2FyZFRhYmxlLmpzeA==) | `87.5% <0%> (ø)` | |
| [...erset/assets/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9pbmplY3RDdXN0b21Dc3MuanM=) | `91.66% <0%> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQ29sb3JQaWNrZXJDb250cm9sLmpzeA==) | `85% <0%> (ø)` | |
| ... and [330 more](https://codecov.io/gh/apache/incubator-superset/pull/8325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=footer). Last update [cff10eb...ddcb556](https://codecov.io/gh/apache/incubator-superset/pull/8325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org