[Bug 60771] New: testFindAllClassesInJar(org.apache.jorphan.reflect.TestClassFinder) can fail on Windows

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60771

            Bug ID: 60771
           Summary: testFindAllClassesInJar(org.apache.jorphan.reflect.Tes
                    tClassFinder) can fail on Windows
           Product: JMeter
           Version: 3.1
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: sebb@apache.org
  Target Milestone: ---

The test testFindAllClassesInJar(org.apache.jorphan.reflect.TestClassFinder)
can fail on Windows.

This can occur if the classpath uses a lower case drive letter whereas the
target jar uses upper case. It seems the Jenkins Windows installation defines
the current working directory (user.dir) and the classpath with a lower-case
drive letter, whereas normally drive letters are upper-case.

A simple fix is to force the drive letters to upper case in the
ClassFinder.fixPathEntry(String path) method.

It would be better to use something like File.getCanonicalPath.
However this makes the name absolute which could cause problems with the
matching process as that uses String.endsWith rather than equals

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60771] testFindAllClassesInJar(org.apache.jorphan.reflect.TestClassFinder) can fail on Windows

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60771

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60771] testFindAllClassesInJar(org.apache.jorphan.reflect.TestClassFinder) can fail on Windows

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60771

--- Comment #1 from Sebb <se...@apache.org> ---
Fixed (for now):

URL: http://svn.apache.org/viewvc?rev=1784148&view=rev
Log:
testFindAllClassesInJar(org.apache.jorphan.reflect.TestClassFinder) can fail on
Windows
Bugzilla Id: 60771

Modified:
jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java

URL: http://svn.apache.org/viewvc?rev=1784151&view=rev
Log:
testFindAllClassesInJar(org.apache.jorphan.reflect.TestClassFinder) can fail on
Windows
Oops, not enough escaping
Bugzilla Id: 60771

Modified:
jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java

-- 
You are receiving this mail because:
You are the assignee for the bug.