You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "LoyeMei (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 08:30:23 UTC
[jira] [Created] (LOG4NET-327) in AppenderSkeleton.Append should
check next Filter while got a FilterDecision.Neutral
in AppenderSkeleton.Append should check next Filter while got a FilterDecision.Neutral
--------------------------------------------------------------------------------------
Key: LOG4NET-327
URL: https://issues.apache.org/jira/browse/LOG4NET-327
Project: Log4net
Issue Type: Bug
Components: Appenders
Affects Versions: 1.2.9
Reporter: LoyeMei
public void DoAppend(LoggingEvent loggingEvent)
{
....................................
while(f != null)
{
switch(f.Decide(loggingEvent))
{
case FilterDecision.Deny:
return; // Return without appending
case FilterDecision.Accept:
f = null; // Break out of the loop
break;
case FilterDecision.Neutral:
f = f.Next; // Move to next filter
break; //Error here ,It should be "continue" here
}
}
...............
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (LOG4NET-327) in AppenderSkeleton.Append should
check next Filter while got a FilterDecision.Neutral
Posted by "LoyeMei (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4NET-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
LoyeMei closed LOG4NET-327.
---------------------------
Resolution: Not A Problem
Fix Version/s: 1.2.9
It is not a problem,I am wrong
> in AppenderSkeleton.Append should check next Filter while got a FilterDecision.Neutral
> --------------------------------------------------------------------------------------
>
> Key: LOG4NET-327
> URL: https://issues.apache.org/jira/browse/LOG4NET-327
> Project: Log4net
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 1.2.9
> Reporter: LoyeMei
> Labels: AppenderSkeleton.Append
> Fix For: 1.2.9
>
>
> public void DoAppend(LoggingEvent loggingEvent)
> {
> ....................................
> while(f != null)
> {
> switch(f.Decide(loggingEvent))
> {
> case FilterDecision.Deny:
> return; // Return without appending
> case FilterDecision.Accept:
> f = null; // Break out of the loop
> break;
> case FilterDecision.Neutral:
> f = f.Next; // Move to next filter
> break; //Error here ,It should be "continue" here
> }
> }
> ...............
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (LOG4NET-327) in AppenderSkeleton.Append should
check next Filter while got a FilterDecision.Neutral
Posted by "Ron Grabowski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4NET-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238068#comment-13238068 ]
Ron Grabowski commented on LOG4NET-327:
---------------------------------------
Why do you think that? The break means the switch statement will exit and return control to the while loop.
> in AppenderSkeleton.Append should check next Filter while got a FilterDecision.Neutral
> --------------------------------------------------------------------------------------
>
> Key: LOG4NET-327
> URL: https://issues.apache.org/jira/browse/LOG4NET-327
> Project: Log4net
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 1.2.9
> Reporter: LoyeMei
> Labels: AppenderSkeleton.Append
>
> public void DoAppend(LoggingEvent loggingEvent)
> {
> ....................................
> while(f != null)
> {
> switch(f.Decide(loggingEvent))
> {
> case FilterDecision.Deny:
> return; // Return without appending
> case FilterDecision.Accept:
> f = null; // Break out of the loop
> break;
> case FilterDecision.Neutral:
> f = f.Next; // Move to next filter
> break; //Error here ,It should be "continue" here
> }
> }
> ...............
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira