You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/18 16:49:00 UTC

[jira] [Work logged] (AMQ-6905) Resource Adapter clientId ActivationConfigProperty does conform to API document

     [ https://issues.apache.org/jira/browse/AMQ-6905?focusedWorklogId=345407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345407 ]

ASF GitHub Bot logged work on AMQ-6905:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Nov/19 16:48
            Start Date: 18/Nov/19 16:48
    Worklog Time Spent: 10m 
      Work Description: jbonofre commented on pull request #278: AMQ-6905 : Upgraded ActivationConfigProperty as per API Documentation
URL: https://github.com/apache/activemq/pull/278
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 345407)
    Remaining Estimate: 0h
            Time Spent: 10m

> Resource Adapter clientId ActivationConfigProperty does conform to API document 
> --------------------------------------------------------------------------------
>
>                 Key: AMQ-6905
>                 URL: https://issues.apache.org/jira/browse/AMQ-6905
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: RAR
>    Affects Versions: 5.15.3
>            Reporter: Darren Merritt
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 5.16.0, 5.15.11
>
>         Attachments: AMQ-6905.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> According to the following page [http://activemq.apache.org/activation-spec-properties.html]
> The clientId default is set by the resource adapter. This is not the case in the code.
> When defining the MDB to be Durable via subscriptionDurability, if the clientId is not configured an validation error is thrown stating "clientId must be set since durable subscription was requested".
> Looking at the code, if the documentation is correct, the ActiveMQActivationSpec validation method should no longer validate the clientId. The ActiveMQConnection makeConnection should change
> String clientId = activationSpec.getClientId();
> to
> String clientId = defaultValue(activationSpec.getClientId(), getInfo().getClientid());
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)