You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/07/11 01:00:31 UTC

[kudu-CR] rpcz: print timeout units (ms) when logging 

Hello Dan Burkert, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10915

to review the following change.


Change subject: rpcz: print timeout units (ms) when logging
......................................................................

rpcz: print timeout units (ms) when logging

Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
---
M src/kudu/rpc/rpcz_store.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/10915/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] rpcz: print timeout units (ms) when logging

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10915 )

Change subject: rpcz: print timeout units (ms) when logging
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 23:08:11 +0000
Gerrit-HasComments: No

[kudu-CR] rpcz: print timeout units (ms) when logging

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10915 )

Change subject: rpcz: print timeout units (ms) when logging
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc
File src/kudu/rpc/rpcz_store.cc:

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc@252
PS1, Line 252:                    << call->header_.timeout_millis() << "ms).";
> How about using HumanReadableElapsedTime in human_readable.h?  Will make th
if so it would be nice to actually print it twice, like 12532ms (12.5sec) or something, since the non-human-readable form is a bit nicer for consumption by grep



-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 19:03:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] rpcz: print timeout units (ms) when logging

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10915 )

Change subject: rpcz: print timeout units (ms) when logging
......................................................................

rpcz: print timeout units (ms) when logging

Also print in human-readable format, which is easier to read for large
values, for both the duration and the timeout. Since the human-readable
version leaves a space between the value and the unit, do the same.

Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Reviewed-on: http://gerrit.cloudera.org:8080/10915
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/rpc/rpcz_store.cc
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] rpcz: print timeout units (ms) when logging

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10915 )

Change subject: rpcz: print timeout units (ms) when logging
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc
File src/kudu/rpc/rpcz_store.cc:

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc@252
PS1, Line 252:                    << call->header_.timeout_millis() << "ms).";
How about using HumanReadableElapsedTime in human_readable.h?  Will make this a little bit easier to work when the timeouts are big.



-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 11 Jul 2018 18:48:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] rpcz: print timeout units (ms) when logging

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10915 )

Change subject: rpcz: print timeout units (ms) when logging
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc
File src/kudu/rpc/rpcz_store.cc:

http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc@252
PS1, Line 252:                    << call->header_.timeout_millis() << "ms).";
> if so it would be nice to actually print it twice, like 12532ms (12.5sec) o
Good suggestions, will do.



-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 19:15:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] rpcz: print timeout units (ms) when logging

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10915

to look at the new patch set (#2).

Change subject: rpcz: print timeout units (ms) when logging
......................................................................

rpcz: print timeout units (ms) when logging

Also print in human-readable format, which is easier to read for large
values, for both the duration and the timeout. Since the human-readable
version leaves a space between the value and the unit, do the same.

Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
---
M src/kudu/rpc/rpcz_store.cc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/10915/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>