[GitHub] [iceberg] rdblue commented on pull request #5157: Prevent StructLikeWrapper#equals from throwing an exception

[GitBox <gi...@apache.org>]

rdblue commented on PR #5157:
URL: https://github.com/apache/iceberg/pull/5157#issuecomment-1170058243

   > Based on the class description it sounded like the whole point of the Wrapper is to be able to compare StructLikes using equals.
   
   The point was to compare structs that have the same type. Normally, we try to do type checking up front because a type describes a large group of rows. Rather than checking each row's type, we want to check types and then check rows. That said, this should be a fast check if the types are identical.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org