You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2013/01/17 11:28:16 UTC

[jira] [Comment Edited] (ZOOKEEPER-1324) Remove Duplicate NEWLEADER packets from the Leader to the Follower.

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556035#comment-13556035 ] 

Flavio Junqueira edited comment on ZOOKEEPER-1324 at 1/17/13 10:28 AM:
-----------------------------------------------------------------------

Hi Alex,

This is indeed kind of unfortunate. I gave it a number of days between +1'ing it and committing so that people could also review and comment. No one did, so I committed it. In general, I agree that you don't have to understand what every single patch that touches zk core does in detail, but it would be great if you could scan the list for issues that could affect ZOOKEEPER-107 and flag it by linking the jiras. There are other jiras coming that could affect ZOOKEEPER-107, like ZOOKEEPER-1549, ZOOKEEPER-1551, ZOOKEEPER-1552, so we need to keep it in mind. We haven't been doing a good job with marking the components that jiras affect, so I'll try to be more careful about that.

I'd rather not revert this patch, but I'd say that we can help you port the patch. If Thawan doesn't have the time, I'll help you out. 
                
      was (Author: fpj):
    Hi Alex,

This is indeed kind of unfortunate. I gave it a number of days between +1'ing it and committing so that people could also review and comment. No one did, so I committed it. In general, I agree that you don't have to understand what every single patch that touches zk core does in detail, but it would be great if you could scan the list for issues that could affect ZOOKEEPER-107 and flag it by linking the jiras. There are other jiras coming that could affect ZOOKEEPER-107, like ZOOKEEPER-1549, ZOOKEEPER-1551, ZOOKEEPER-1552, so we need to keep it in mind. We have been doing a good job with marking the components that jiras affect, so I'll try to be more careful about that.

I'd rather not revert this patch, but I'd say that we can help you port the patch. If Thawan doesn't have the time, I'll help you out. 
                  
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1324
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>            Reporter: Mahadev konar
>            Assignee: Thawan Kooburat
>            Priority: Critical
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira