You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/29 15:54:37 UTC

[GitHub] [ignite-3] tledkov-gridgain commented on a change in pull request #410: IGNITE-15669 Get rid of leakage of Calcite classes through SqlCursor class

tledkov-gridgain commented on a change in pull request #410:
URL: https://github.com/apache/ignite-3/pull/410#discussion_r739352211



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -579,11 +583,28 @@ private void register(QueryInfo info) {
     }
 
     /** */
-    private FieldsMetadata queryFieldsMetadata(PlanningContext ctx, RelDataType sqlType,
+    private ResultSetMetadataInternal resultSetMetadata(PlanningContext ctx, RelDataType sqlType,
         @Nullable List<List<String>> origins) {
         RelDataType resultType = TypeUtils.getResultType(
             ctx.typeFactory(), ctx.catalogReader(), sqlType, origins);
-        return new FieldsMetadataImpl(resultType, origins);
+
+        List<ResultFieldMetadata> fields = new ArrayList<>(resultType.getFieldCount());
+
+        for (int i = 0; i < resultType.getFieldCount(); ++i) {

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org